-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bytes literals in Python3 #759
Conversation
/ok-to-test
On Thu, May 3, 2018 at 9:38 PM k8s-ci-robot ***@***.***> wrote:
Hi @gangliao <https://github.com/gangliao>. Thanks for your PR.
I'm waiting for a kubeflow <https://github.com/orgs/kubeflow/people>
member to verify that this patch is reasonable to test. If it is, they
should reply with /ok-to-test on its own line. Until that is done, I will
not automatically test new commits in this PR, but the usual testing
commands by org members will still work. Regular contributors should join
the org <https://github.com/kubeflow/kubeflow/blob/master/CONTRIBUTING.md>
to skip this step.
I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/devel/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#759 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAwpFbnYqgo49XfAmpidlbIHO75bIF5Kks5tu9tSgaJpZM4TyGns>
.
--
Ankush Agarwal
Software Engineer, Cloud ML
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ankushagarwal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)
fix #760